RFR: 8370884: JFR: Overflow in aggregators
Francesco Andreuzzi
fandreuzzi at openjdk.org
Wed Nov 5 09:09:05 UTC 2025
On Tue, 4 Nov 2025 16:23:53 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a change that fixes overflow issues for the jfr query aggregators?
>
> Testing: jdk/jdk/jfr
>
> Thanks
> Erik
src/jdk.jfr/share/classes/jdk/jfr/internal/query/Function.java line 383:
> 381: seconds = Math.addExact(s, nanosToAdd / NANOS_PER_SECOND);
> 382: nanos = nanos + nanosToAdd % NANOS_PER_SECOND;
> 383: hasValue = true;;
Suggestion:
hasValue = true;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28135#discussion_r2493592341
More information about the hotspot-jfr-dev
mailing list