RFR: 8365606: Container code should not be using jlong/julong [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 10 13:10:09 UTC 2025


On Mon, 27 Oct 2025 14:13:57 GMT, Thomas Fitzsimmons <fitzsim at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>>  - Fix print_container_info output
>>  - whitespace clean-ups and other small fixes
>>  - Fix log format in container macro and scanf format
>>  - Fix duplicate include in osContainer_linux
>>  - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 627:
> 
>> 625:  *
>> 626:  * If quotas have not been specified, return the
>> 627:  * number of active processors in the system.
> 
> This paragraph uses the "return" language that you adjusted in the next paragraph.  It should probably also refer to the reference argument instead.

Thanks, fixed.

> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 629:
> 
>> 627:  * number of active processors in the system.
>> 628:  *
>> 629:  * If quotas have been specified, the resulting number
> 
> Tiny nit, but "the resulting number" => "the number", since you say "the result reference" on the next line.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510514731
PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510515207


More information about the hotspot-jfr-dev mailing list