RFR: 8365606: Container code should not be using jlong/julong [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 10 17:22:39 UTC 2025


On Mon, 27 Oct 2025 11:36:39 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>>  - Fix print_container_info output
>>  - whitespace clean-ups and other small fixes
>>  - Fix log format in container macro and scanf format
>>  - Fix duplicate include in osContainer_linux
>>  - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 115:
> 
>> 113:  *    true if the result reference has been set
>> 114:  *    false on error
>> 115:  */
> 
> The beginning part of the comment isn't updated to mention the `result` reference, unlike the other comments.

Should be fixed in https://github.com/openjdk/jdk/pull/27743/commits/46df71e19458b1682d6b8a28ef5b3e9a8932be9e

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2511363227


More information about the hotspot-jfr-dev mailing list