RFR: 8282427: jdk/jfr/jvm/TestWaste.java is failing with "exit code 139"
SendaoYan
syan at openjdk.org
Tue Oct 14 03:38:07 UTC 2025
On Tue, 14 Oct 2025 00:07:44 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I get a review for a PR that relaxes an assert? When removing the last parent in a frontier, the queue can fill while processing its children, causing _dfs_fallback_idx to equal _next_frontier_idx.
>
> Testing: 5000 * test/jdk/jdk/jfr/jvm/TestWaste.java
>
> Thanks
> Erik
src/hotspot/share/jfr/leakprofiler/chains/bfsClosure.cpp line 192:
> 190: // fallback onto DFS as part of processing the frontier
> 191: assert(_dfs_fallback_idx >= _prev_frontier_idx, "invariant");
> 192: assert(_dfs_fallback_idx =< _next_frontier_idx, "invariant");
Does `=<` should be `<=` ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27779#discussion_r2427822343
More information about the hotspot-jfr-dev
mailing list