RFR: 8377798: Hotspot build on macOS aarch64 with unused-functions warning reports some unused functions
David Holmes
dholmes at openjdk.org
Wed Feb 18 01:57:50 UTC 2026
On Fri, 13 Feb 2026 08:47:41 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> src/hotspot/os/posix/perfMemory_posix.cpp line 497:
>>
>>> 495: }
>>> 496:
>>> 497: #ifndef __APPLE__
>>
>> Shouldn't this be a big `ifdef __APPLE__` before `get_user_name(uid_t uid) ` and this becomes the `#else` part?
>
> Seems mmap_create_shared uses the one-parameter get_user_name across POSIX platforms, so we cannot do this.
That seems very suspicious to me. I would expect `mmap_create_shared` and `mmap_attach_shared` to work the same way with regards to getting the user and the tmp directory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29695#discussion_r2819943713
More information about the hotspot-jfr-dev
mailing list