RFR: 8367949: JFR: MethodTrace double-counts methods that catch their own exceptions [v2]
Robert Toyonaga
duke at openjdk.org
Wed Jan 7 14:08:30 UTC 2026
On Wed, 7 Jan 2026 10:08:11 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Could I have a review of a PR that changes how the instrumentation of the MethodTrace and MethodTiming events is implemented, so they handle exceptions in a better way?
>>
>> For constructors, the current implementation is still used in certain corner cases. A proper implementation would require data-flow analysis, but for all practical purposes this code should work fine.
>>
>> Testing: jdk/jdk/jfr
>>
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>
> Formatting + reuse of local variable
Marked as reviewed by roberttoyonaga at github.com (no known OpenJDK username).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28947#pullrequestreview-3635059497
More information about the hotspot-jfr-dev
mailing list