RFR: 8367949: JFR: MethodTrace double-counts methods that catch their own exceptions [v3]

Erik Gahlin egahlin at openjdk.org
Thu Jan 8 11:26:54 UTC 2026


> Could I have a review of a PR that changes how the instrumentation of the MethodTrace and MethodTiming events is implemented, so they handle exceptions in a better way? 
> 
> For constructors, the current implementation is still used in certain corner cases. A proper implementation would require data-flow analysis, but for all practical purposes this code should work fine.
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:

  Use simplified instrumentation for java.lang.Object::<init>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28947/files
  - new: https://git.openjdk.org/jdk/pull/28947/files/f97e2ad3..4897a25e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28947&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28947&range=01-02

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/28947.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28947/head:pull/28947

PR: https://git.openjdk.org/jdk/pull/28947


More information about the hotspot-jfr-dev mailing list