Resend: Review request (6204603 new Solaris mmap semantics for class data archive file)

Steve Bohne Stephen.Bohne at Sun.COM
Mon Mar 10 07:41:52 PDT 2008


I need one more review for this please.

Thanks,
Steve

-------- Original Message --------
Subject: Review request (6204603 new Solaris mmap semantics for class 
data	archive file)
Date: Tue, 04 Mar 2008 11:07:51 -0500
From: Steve Bohne <Stephen.Bohne at Sun.COM>
To: hotspot-runtime-dev at openjdk.java.net

Thanks for any reviews.

Fixed 6204603: Modify hotspot to use new Solaris mmap semantics for
class data archive file

http://web-east.east/~sbohne/webrev/6204603

Modify Solaris os::attempt_reserve_memory_at() to pass an address hint
to mmap when reserving memory for the shared archive.  Previously we
used successive anonymous mmap calls to "zero in" on the correct region.
Since snv_84 (see 5003415) Solaris will attempt to honor the address
hint.  If the new call fails, we simply fall back to the old method.

Reviewed by:

Fix verified (y/n): y

Verification testing:
    java -client -Xshare:on -XX:+PrintMiscellaneous -XX:+Verbose -version
      (fastdebug, Solaris SPARC + x86)

Other testing:
    NSK vm.quick -client Solaris SPARC + x86
    JPRT


Thanks,
Steve


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6204603.diff.txt
Url: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20080310/0ed7a72c/attachment.txt 


More information about the hotspot-runtime-dev mailing list