request for review (XS)

[Volker Simonis]

That's indeed a nice test and the only question that arises is why it
isn't part of the JCK-Testsuite?

Regards,
Volker

On 5/22/08, Martin Buchholz <martinrb at google.com> wrote:
> Please examine the test
>  jdk/test/java/lang/System/Versions.java
>  and make sure it passes on JDK6 and JDK7,
>  and that all system properties are correctly maintained.
>  This test was specifically written to catch mismatches
>  between hotspot and jdk versions.
>
>  (I've long argued that hotspot integrators should guarantee
>  that they don't break tests in java.lang or java.util, but I don't
>  believe that has happened yet)
>
>
>  Martin
>
>
>
>  On Thu, May 22, 2008 at 6:16 AM, Keith McGuigan <Keith.McGuigan at sun.com> wrote:
>  > http://webrev.invokedynamic.info/kamg/6705523/
>  >
>  > This fix has the classfiler parser accept classfiles with version 51 only
>  > when the VM is run in the context of JDK7 (or greater).  For JDK6, version
>  > 50 is the max accepted classfile version.
>  >
>  > The change in sharedRuntime_sparc.cpp is an unrelated change to eliminate a
>  > compile warning.
>  >
>  > Thanks for any review.
>  >
>  > --
>  > - Keith
>  >
>