Request for reviews (S): 6860920: serialize.cpp shouldn't use objArrayOopDesc::base_offset_in_bytes(T_BYTE)

Coleen Phillimore Coleen.Phillimore at Sun.COM
Thu Jul 16 06:08:48 PDT 2009


I think this looks good and is much cleaner.  At one point of the 
Compressed Oops development, base_offset_in_bytes(T_OBJECT) was rounding 
up to the 3rd 64 bit word, which is wrong, so I might have set this to 
T_BYTE for that reason.  I think all that got fixed with further 
development, but can you please check that the answer you get for 
compressed oops is 2*64 bits and without compressed oops is 3*64 bits.
Thanks,
Coleen

Christian Thalinger wrote:
> As discussed on hotspot-dev, here is the proposed patch:
>
> http://cr.openjdk.java.net/~twisti/6860920/webrev.01/
>
> -- Christian
>   



More information about the hotspot-runtime-dev mailing list