Please Review (S): CR 6782663: Data produced by PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime is not accurate

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Tue Jul 21 14:21:45 PDT 2009


John,

Looks good.
In vmThread.cpp add flag name into asserts message otherwise
it is not clear what a flag the asserts complain about.

Thanks,
Vladimir

john cuthbertson - Sun Microsystems wrote:
> Hi David,
> 
> Thank you for the review and answering my questions. I have applied the 
> comments that you and Vladimir have suggested. I went with your 
> suggestions for the new flag names as they do accurately describe what 
> is being measured and displayed/logged.
> 
> The new webrev can be found at:
> 
> http://cr.openjdk.java.net/~johnc/6782663/webrev.01/
> 
> Can I have a couple of volunteers look these changes over?
> 
> Thanks,
> 
> JohnC



More information about the hotspot-runtime-dev mailing list