Please Review (S): CR 6782663: Data produced by PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime is not accurate

[John Coomes]

john cuthbertson - Sun Microsystems (John.Cuthbertson at Sun.COM) wrote:
> Hi David,
> 
> Thank you for the review and answering my questions. I have applied the 
> comments that you and Vladimir have suggested. I went with your 
> suggestions for the new flag names as they do accurately describe what 
> is being measured and displayed/logged.
> 
> The new webrev can be found at:
> 
> http://cr.openjdk.java.net/~johnc/6782663/webrev.01/
> 
> Can I have a couple of volunteers look these changes over?

Hi John,

First, apologies for not noticing this earlier.

Your original webrev (webrev.00) removed the print statements in
vmThread.cpp.  Based upon David Holmes' comments (I believe) this
version restores them, which keeps the existing (buggy) behavior of
missing time in jdk6 when the old names are used.  I think that's
taking compatibility too far; we should get rid of the buggy behavior
completely.

-John