Minor issue in JVM_GetVersionInfo

Andrew John Hughes gnu_andrew at member.fsf.org
Fri Oct 30 09:56:36 PDT 2009


2009/10/30 Michael Starzinger <michi at complang.tuwien.ac.at>:
> Hello!
>
> Some days ago I examined the implementation of JVM_GetVersionInfo and
> spotted a minor issue. The passed jvm_version_info structure is only
> partially cleared with memset, because one of the arguments is handled
> incorrectly. The attached patch should fix the issue.
>
> This is the first time I am contributing to OpenJDK, so please let me know
> if there is anything else I need to do to get this in.
>
> -michi
>
>
>

Hi Michi,

First thing is, have you signed the SCA?
http://sun.com/software/opensource/sca.pdf  Even though this is a
trivial patch, Sun requires assignment for all patches.

The patch looks ok to me and still applies to the latest promoted
HotSpot about to appear in b75.  So once you have the SCA sorted, all
we need is for one of the HotSpot engineers to approve it, assign it a
bug ID and push it through JPRT.

For convenience, here's a webrev of the change applied to hotspot-rt:
http://cr.openjdk.java.net/~andrew/michi/webrev.01/
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


More information about the hotspot-runtime-dev mailing list