Review request: 6378314: Bad warning message when agent library not found. local directory is not searched.

Chuck Rasbold rasbold at google.com
Wed Aug 4 11:20:17 PDT 2010


Thanks, John.

The nits have been fixed and the webrev updated.

http://cr.openjdk.java.net/~rasbold/6378314/

-- Chuck

On Tue, Aug 3, 2010 at 4:36 PM, John Coomes <John.Coomes at oracle.com> wrote:

> Chuck Rasbold (rasbold at google.com) wrote:
> > http://cr.openjdk.java.net/~rasbold/6378314/
> >
> > Fixed: 6378314: Bad warning message when agent library not found. local
> > directory is not searched.
> > Contributed-by: jeremymanson at google.com
> >
> > Print a more detailed error message for agent library load failure.
>
> Hi Chuck & Jeremy,
>
> Looks ok to me, aside from a couple of nits:  use jio_snprintf instead
> of sprintf, and strlen returns a size_t, so use that to declare len.
>
> -John
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20100804/a85b7fca/attachment.html 


More information about the hotspot-runtime-dev mailing list