Request for review: 6979444

[Ivan Krylov]

>  The actual link in your html went to the wrong webrev :)
Ah, copy-pasting .. should have sent plain-text.. thanks for catching


Tom,

To me it does not matter if values are final or initial there.
Those values are printed as "typical values". I would actually prefer 
those values to be consistent for a given platform.
The point of this fix is printing flags descriptions.
Well, the jprt job is now submitted. I will copy your note to bugster.

Thanks,

Ivan



On 8/30/10 8:55 PM, Tom Rodriguez wrote:
> I recently moved the PrintFlagsFinal code because there are flags which are adjusted after we complete the flag parsing in arguments.cpp:
>
> http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/diff/f55c4f82ab9d/src/share/vm/runtime/init.cpp
>
> You might want to move your new printing code there, assuming you want to see the final values.
>
> tom
>
> On Aug 30, 2010, at 9:27 AM, David Holmes wrote:
>
>>
>> Ivan Krylov said the following on 08/30/10 23:26:
>>>   Bug Link: http://bugs.sun.com/view_bug.do?bug_id=6979444
>>> Webrev: http://cr.openjdk.java.net/~ikrylov/6979444
>> The actual link in your html went to the wrong webrev :)
>>
>> http://cr.openjdk.java.net/%7Ekamg/6930553/webrev.01/
>>
>> but the real webrev seems ok to me.
>>
>> Thanks,
>> David
>>
>>> The following change effects only nonproduct builds. A new boolean flag is introduced: -XX:+PrintFlagsWithComments
>>> It works pretty much like -XX:+PrintFlagsInitial (or -Xprintflags) but adds a doc string to each flag that is present in every flag definition in the corresponding *global*.hpp file.
>>> Minor corrections were made to Flag::print_on method to do proper formatting of all 3 flags (more space for flag name and type, printing of double default values).
>>> Thanks,
>>> Ivan


-- 
Oracle <http://www.oracle.com>
Dr. Ivan Krylov | Java SE Licensee Engineer, EMEA | +7.812.334.6368
Oracle Development SPB
10th Krasnoarmeyskaya 22A, Saint-Petersburg, 190103, Russia

Software. Hardware. Complete. <http://www.oracle.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20100830/171ae656/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20100830/171ae656/attachment-0001.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shc.jpg
Type: image/jpeg
Size: 5215 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20100830/171ae656/attachment-0001.jpg