Review request (S): 6539281 -Xcheck:jni should validate char* argument to ReleaseStringUTFChars
Keith McGuigan
keith.mcguigan at oracle.com
Thu Dec 2 08:34:18 PST 2010
On Dec 2, 2010, at 9:18 AM, Staffan Larsen wrote:
> http://cr.openjdk.java.net/~sla/6539281/webrev.00/
>
> Validate that ReleaseStringUTFChars/ReleaseStringChars is called
> with something allocated by GetStringUTChars/GetStringChars when
> running with -Xcheck:jni. This is accomplished by adding a well-
> known tag in the memory immediately before the pointer that is
> returned to the user. This tag is verified in ReleaseStringUTFChars.
>
> Thanks,
> /Staffan
Looks good to me -- with the very minor nit that the star should be
with the type (jint) instead of the variable name (tagLocation) on
line 1324.
--
- Keith
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20101202/68a7287d/attachment.html
More information about the hotspot-runtime-dev
mailing list