Request for reviews (S): 6999491: non-zero COOPs are used when they should not

[John Coomes]

Vladimir Kozlov (vladimir.kozlov at oracle.com) wrote:
> http://cr.openjdk.java.net/~kvn/6999491/webrev
> 
> Fixed 6999491: non-zero COOPs are used when they should not
> 
> Regression introduced by fix for 6984368 bug.
> The expression in max_heap_for_compressed_oops() produces
> incorrect result when HeapBaseMinAddress > OopEncodingHeapMax.
> 
> HeapBaseMinAddress should be used only for a default heap
> size calculation.
> Added heap size to PrintCompressedOopsMode output.

Couple of nits:

In universe.cpp, reserved_region()->byte_size() returns size_t, so use
SIZE_FORMAT instead of INTX_FORMAT.

arguments.cpp line 1332 should match the surrounding code:  no spaces
inside the parens and use { }, e.g.

  if (OopEncodingHeapMax < MaxPermSize + os::vm_page_size()) {
    return 0;
  }

Otherwise, looks good.

-John