Request for reviews (S): 6934483: GCC 4.5 errors "suggest parentheses around something..." when compiling with -Werror and -Wall

[Chuck Rasbold]

If I'm not too late, and not picking nits...

In referenceProcessor.hpp, we used to have:

 if (_was_discovering_refs = _rp->discovery_enabled())
which was concise, but could cause confusion over "=" vs. "==".

Now we add an extra set of parens, which is less concise and more puzzling.

if ((_was_discovering_refs = _rp->discovery_enabled())) {

Can we do:


     if ((_was_discovering_refs = _rp->discovery_enabled())) {


instead?


On Wed, Sep 8, 2010 at 8:06 AM, Christian Thalinger <
christian.thalinger at oracle.com> wrote:

> On Wed, 2010-09-08 at 07:41 -0700, Vladimir Kozlov wrote:
> > Looks good.
>
> Thanks, Vladimir.  -- Christian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20100908/ec429ec8/attachment.html