Review Request (XS) 7005503 Make GuaranteedSafepointInterval a diagnostic flag

[David Holmes]

Hi Kevin,

In terms of the code review - looks good :)

But I think you need buy-in from Karen or Paul as to the "rightness" of 
making this change. I don't see an issue with it.

David

Kevin Walls said the following on 04/18/11 20:33:
> Hi,
> 
> Just a one-liner request.  embedded already has this as a product flag, 
> so this changes it in non-embedded only:
> 
> Thanks
> Kevin
> 
> $ hg diff   src/share/vm/runtime/globals.hpp
> diff --git a/src/share/vm/runtime/globals.hpp 
> b/src/share/vm/runtime/globals.hpp
> --- a/src/share/vm/runtime/globals.hpp
> +++ b/src/share/vm/runtime/globals.hpp
> @@ -2886,7 +2886,7 @@ class CommandLineFlags {
>            "Max. no. of lines in the stack trace for Java exceptions 
> "       \
>            "(0 means 
> all)")                                                  \
>                                                                              
> \
> -  NOT_EMBEDDED(develop(intx, GuaranteedSafepointInterval, 
> 1000,             \
> +  NOT_EMBEDDED(diagnostic(intx, GuaranteedSafepointInterval, 
> 1000,          \
>            "Guarantee a safepoint (at least) every so many milliseconds 
> "    \
>            "(0 means 
> none)"))                                                \
>                                                                              
> \
> 
> 
> 
>