SECOND CALL: code review for jvmstat/jps fix (6954420)

[Karen Kinnear]

Dan,

Approved.

Looks very tricky to track down.

Only minor suggestion - line 1361 warning: if ret_code == OS_ERR, it  
might be nice to
print %s and strerror(errno) rather than %d and ret_code. Not a big  
deal.

thanks,
Karen

On Feb 15, 2011, at 7:49 PM, Daniel D. Daugherty wrote:

> I need a Runtime team reviewer!
>
> Dan
>
> On 2/14/2011 4:02 PM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> I have a fix for the following jvmstat/jps bug:
>>
>> 6954420: 2/4 jps shows "process information unavailable" sometimes
>> Summary: Make sure the backing store file is flushed in  
>> create_sharedmem_resources() and get_user_name_slow() no longer  
>> checks the size of the backing store file.
>> Reviewed-by:
>>
>> Here is the URL for the webrev:
>>
>>   http://cr.openjdk.java.net/~dcubed/6954420-webrev/0/
>>
>> Thanks, in advance, for any reviews.
>>
>> Dan
>>
>>
>>