Request for review: 7019689: Non-dependent name is found in dependent base class although it should,be rejected

Coleen Phillimore coleen.phillimore at oracle.com
Tue Feb 15 20:29:25 PST 2011


On 2/15/2011 9:44 PM, Poonam Bajaj wrote:
> Hi Coleen,
>
> Fix looks good.
>
> Just noticed that the bug is not visible publically in bugs.sun.com, 
> so maybe
> you can send a brief discription of the problem to the alias.

Thanks Poonam, The bug comes from an email that Volker Simonis sent and 
I cut/pasted this into the synopsis:

"Notice that this patch contains one additional change compared to the
patch in the blog. While I did the tests for the blog with an 
slightlyoutdated HS20b03 I synced a brand new version today to prepare 
the patch. With this new version I found a true C++ bug 
in"src/share/vm/utilities/hashtable.hpp" which was introduced recently 
by the "6990754: Use native memory and reference counting to 
implementSymbolTable" change and which has to do with name lookup of 
nondependent names in dependent base classes 
(seehttp://www.parashift.com/c++-faq-lite/templates.html#faq-35.19 for a 
nice explanation). Wouldn't have happened with Clang:)"

The bugs.sun.com bug should appear soon (maybe in a day or two).

Thanks,
Coleen
>
> Thanks,
> Poonam
>
> On 2/16/2011 2:26 AM, Coleen Phillimore wrote:
>> Summary: fix hashtable.hpp to qualify non-dependant name with "this"
>> Contributed-by: volker.simonis at gmail.com
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/7019689/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=7019689
>>
>> Tested additionally with windows and solaris builds.
>>
>> Thanks,
>> Coleen
>>



More information about the hotspot-runtime-dev mailing list