Request for review (S) 7017193: Small memory leak in get_stack_bounds // os::create_stack_guard_pages

[Dmitry Samersoff]

David,

As discussed off-line with Coleen - I'll prepare more readable fix.

-Dmitry


On 2011-02-22 02:47, David Holmes wrote:
> Dmitry,
>
> Dmitry Samersoff said the following on 02/21/11 22:20:
>> Hi Everyone,
>>
>> http://cr.openjdk.java.net/~dsamersoff/7017193
>>
>> I'm uncomfortable with one malloc/free cycle per line so decided to
>> get rid of getline() call completely.
>
> As I stated in the CR you do not have to do one malloc/free per line
> with getline. The buffer can be reused and will be realloc'd if needed
> by getline, and then can be freed at the end.
>
> I can't evaluate your change without understanding both the detailed
> logic of the original code and your new code.
>
> David


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...