Request for review (S): 7022037: Pause when exiting if a debugger is attached on windows

[Staffan Larsen]

> -----Original Message-----
> From: Keith McGuigan
> Sent: den 25 februari 2011 16:14
> To: Staffan Larsen
> Cc: Dmitriy Samersoff; hotspot-runtime-dev at openjdk.java.net
> Subject: Re: Request for review (S): 7022037: Pause when exiting if a
> debugger is attached on windows
> 
> 
> I think that looks better, thanks for making those changes.  Two
> minor
> issues:
> 
> (1) os.hpp:496 - you don't need the "os::" prefix here.

Doh. Copy-paste-error.

> (2) (and this isn't a big deal) Why go through the work in the
> arguments code to determine the launcher and store that result rather
> than just looking at the _sun_java_launcher value at the time that
> you
> need it (in check_and_debugger_and_wait())?

I just wanted to have the code in one place. Arguments::created_by_gamma_launcher() is currently called from three different places.

/Staffan