review request (S): 6962930 make the string table size configurable

[John Coomes]

Tom Rodriguez (tom.rodriguez at oracle.com) wrote:
> Oops.  That line should be deleted too, along with the declaration of stringTableSize in StringTable.java.

Thanks.  I fixed that and some other nits and updated the webrev at
the same location:

http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/

-John

> On Feb 16, 2011, at 10:29 AM, Paul Hohensee wrote:
> 
> > It does.  See agent/src/share/classes/sun/jvm/hotspot/memory/StringTable.java.
> > 
> >    stringTableSize = db.lookupIntConstant("StringTable::string_table_size").intValue();
> > 
> > Paul
> > 
> > On 2/16/11 1:15 PM, Keith McGuigan wrote:
> >> 
> >> Looks good.  Nothing in the SA agent was calling getStringTableSize()?
> >> 
> >> On Feb 16, 2011, at 1:06 PM, John Coomes wrote:
> >> 
> >>> I'd appreciate reviews of a small change to allow the string table
> >>> size to be set on the command line:
> >>> 
> >>> http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/
> >>> 
> >>> -John
> >>> 
> >> 
>