Request for review (S) 4926272: methodOopDesc::method_from_bcp is unsafe

Coleen Phillimore coleen.phillimore at oracle.com
Mon Jan 3 13:38:33 PST 2011


Ramki and Keith pointed out that there is a non-zero probability that 
constMethodKlass's address could look like a set of bytecodes so we 
could fail to search up to the top of the constMethodOop type.  A new 
cleaner webrev which solves the problem for when there is no permgen is 
available here.   This was tested with 32 and 64 bit with the failing 
testcases and -XX:+UseConcMarkSweepGC.  Please review.

open webrev at http://cr.openjdk.java.net/~coleenp/4926272_2/

Thanks,
Coleen

On 12/29/2010 6:18 PM, Coleen Phillimore wrote:
> Summary: Instead of using GC to find the block start, scan backward in 
> memory to known contents in the constMethodOop
>
> open webrev at http://cr.openjdk.java.net/~coleenp/4926272/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=4926272
>
> Tested on 32 and 64 bit platforms with the test cases that reliably 
> failed.
>
> Thanks,
> Coleen
>



More information about the hotspot-runtime-dev mailing list