Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling

John Coomes John.Coomes at oracle.com
Wed Jan 5 15:26:20 PST 2011


Coleen Phillimore (coleen.phillimore at oracle.com) wrote:
> Summary: Call get_thread_slow() in vm_perform_shutdown actions and add 
> null check.
> 
> Tested by forcing vm_exit_out_of_memory in current_stack_region (if 
> is_init_completed) to reproduce the bug.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/6583275/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=6583275

You should use ThreadLocalStorage::is_initialized() instead of
checking for -1.  Other than that, looks good.

-John



More information about the hotspot-runtime-dev mailing list