Request for review: 7046490 - Preallocated OOME objects should obey Throwable stack trace protocol

Mandy Chung mandy.chung at oracle.com
Mon Jul 11 18:12:37 PDT 2011


  Hi David,

On 7/7/11 1:25 PM, David Holmes wrote:
> http://cr.openjdk.java.net/~dholmes/7046490/webrev/
>
> This is a simple fix in the VM to honour the Throwable immutability 
> protocol that was defined for Java 7. Pre-allocated Throwable 
> instances are normally immutable, but that is not the case for a group 
> of pre-allocated OutOfMemoryError instances. To conform to the 
> protocol, when we set the backtrace (VM representation of the 
> stackTrace) we have to set the stackTrace field to the sentinel value 
> stored in the static Throwable.UNASSIGNED_STACK field.

This fix looks good.  I assume you still need a reviewer for this fix :)

Mandy



More information about the hotspot-runtime-dev mailing list