Fwd: Code review request: 7067266 Decoder class not properly initialized on Windows

[Zhengyu Gu]

Forward to openjdk for review:

Webrev: http://cr.openjdk.java.net/~zgu/7067266/webrev.00/

Thanks,

-Zhengyu

-------- Original Message --------
Subject: 	Re: Code review request: 7067266 Decoder class not properly 
initialized on Windows
Date: 	Fri, 15 Jul 2011 11:52:44 -0600
From: 	Daniel D. Daugherty <daniel.daugherty at oracle.com>
Reply-To: 	daniel.daugherty at oracle.com
To: 	Zhengyu Gu <zhengyu.gu at oracle.com>
CC: 	hotspot-runtime-dev-confidential 
<hotspot-runtime-dev-confidential at sun.com>, volker-simonis at gmail.com



Thumbs up on the code.

Zhengyu, this came in via hotspot-runtime-dev at openjdk.java.net
so this review should go out on that alias also (and the webrev
copied to cr.openjdk.java.net)

Dan


On 7/15/11 11:26 AM, Zhengyu Gu wrote:
> This is a simple fix that moves Decoder initialization to step 60 in 
> vmError.cpp, so the decoder can decode "Problematic frame:" in hs file 
> header.
>
> The bug was reported by volker-simonis at gmail.com 
> <mailto:volker-simonis at gmail.com> from SAP with proposed patch. The 
> solution was to move decoder initialization code to
> print_C_frame() function, but it is less optimal, since decoder will 
> have to be initialized and uninitialized every time in/out of the 
> print_C_frame() function.
>
> CR: http://monaco.sfbay.sun.com/detail.jsf?cr=7067266
> Webrev: http://j2se.east.sun.com/~zg131198/7067266/webrev/
>
> Testcase:
>   A simple Java program with JNI call that crashes VM:
>
> JNIEXPORT void JNICALL Java_jni_1excpt_Main_crashVM (JNIEnv *, jclass) {
>   int* p = NULL;
>   *p = 1;
> }
>
> Without fix, hs file header:
>
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x5b431308, pid=7860, 
> tid=4140
> #
> # JRE version: 6.0_23-b05
> # Java VM: Java HotSpot(TM) Client VM (19.0-b09 mixed mode, sharing 
> windows-x86 )
> # Problematic frame:
> # C  [mydll.dll+0x11308]
> #
> # If you would like to submit a bug report, please visit:
> # http://java.sun.com/webapps/bugreport/crash.jsp
> # The crash happened outside the Java Virtual Machine in native code.
> # See problematic frame for where to report the bug.
> #
>
>
> With fix:
>
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x5c981308, pid=1652, 
> tid=5964
> #
> # JRE version: 6.0_23-b05
> # Java VM: Java HotSpot(TM) Client VM (21.0-b16-fastdebug mixed mode 
> windows-x86 )
> # Problematic frame:
> # C  [mydll.dll+0x11308]  Java_jni_1excpt_Main_crashVM+0x28
> #
> # Failed to write core dump. Minidumps are not enabled by default on 
> client versions of Windows
> #
> # If you would like to submit a bug report, please visit:
> # http://bugreport.sun.com/bugreport/crash.jsp
> # The crash happened outside the Java Virtual Machine in native code.
> # See problematic frame for where to report the bug.
> #
>
>
> Thanks,
>
> -Zhengyu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20110715/0e9a9278/attachment.html