Request for review: 7046490 - Preallocated OOME objects should obey Throwable stack trace protocol
Paul Hohensee
paul.hohensee at oracle.com
Mon Jul 18 20:32:06 PDT 2011
Looks good, except, could you use obj_field() in unassigned_stacktrace()
instead
of checking UseCompressedOops there?
Paul
On 7/7/11 1:25 AM, David Holmes wrote:
> http://cr.openjdk.java.net/~dholmes/7046490/webrev/
>
> This is a simple fix in the VM to honour the Throwable immutability
> protocol that was defined for Java 7. Pre-allocated Throwable
> instances are normally immutable, but that is not the case for a group
> of pre-allocated OutOfMemoryError instances. To conform to the
> protocol, when we set the backtrace (VM representation of the
> stackTrace) we have to set the stackTrace field to the sentinel value
> stored in the static Throwable.UNASSIGNED_STACK field.
>
> With this fix in place the workaround in Throwable.java, under
> 7045138, can be backed out.
>
> Thanks,
> David
>
>
>
More information about the hotspot-runtime-dev
mailing list