Request for review (xs) 7021653: Parfait issue in hotspot/src/share/vm/oops/methodDataOops.hpp
John Coomes
John.Coomes at oracle.com
Thu Mar 3 12:14:59 PST 2011
Coleen Phillimore (coleen.phillimore at oracle.com) wrote:
> Summary: Fix compilation error(s)
>
> Also fix new random gcc compiler error in os::free() in gcc 4.4.1.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/7021653/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=7021653
>
> Tested on windows and solaris 64 bit (actually tested with an assert
> that the old calculation == new one).
%x expects an unsigned value, so better to cast to uintptr_t (a total
nit, but gcc is becoming increasingly nit-picky). Other than that,
looks good.
-John
More information about the hotspot-runtime-dev
mailing list