Request for review (xs) 7021653: Parfait issue in hotspot/src/share/vm/oops/methodDataOops.hpp

[Coleen Phillimore]

On 3/3/2011 3:14 PM, John Coomes wrote:
> Coleen Phillimore (coleen.phillimore at oracle.com) wrote:
>> Summary: Fix compilation error(s)
>>
>> Also fix new random gcc compiler error in os::free() in gcc 4.4.1.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/7021653/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=7021653
>>
>> Tested on windows and solaris 64 bit (actually tested with an assert
>> that the old calculation == new one).
> %x expects an unsigned value, so better to cast to uintptr_t (a total
> nit, but gcc is becoming increasingly nit-picky).  Other than that,
> looks good.

Oh thanks for the correction.  I picked intptr_t because the complaint 
was casting void* to (I thought) signed int, but uintptr_t works too and 
that's better.

Thanks,
Coleen
> -John
>