review request (XS): 6728025 LinkResolver missing ResourceMarks

John Coomes John.Coomes at oracle.com
Thu May 5 08:23:35 PDT 2011


David Holmes (David.Holmes at oracle.com) wrote:
> Hi John,
> 
> John Coomes said the following on 05/05/11 12:10:
> > I'd appreciate reviews of a simple fix that adds ResourceMarks to a
> > number of error handling branches in LinkResolver:
> > 
> > http://cr.openjdk.java.net/~jcoomes/6728025-linkresolver-resourcemark/
> 
> Looks fine to me.

Thanks!

> Somewhat surprised this was not discovered immediately. I would have 
> expected that we have tests that exercise all those error paths and 
> surely we would have run them in a debug VM at some stage.

I was surprised too.

-John


More information about the hotspot-runtime-dev mailing list