Request for review (XS): 7106766
David Holmes
david.holmes at oracle.com
Tue Nov 1 02:31:22 PDT 2011
Thanks Rickard, this change looks okay to me.
David
On 1/11/2011 6:13 PM, Rickard Bäckman wrote:
> The URL should be:
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7106766
> but it seems it is not yet visible.
>
> /Rickard
>
> On 11/01/2011 08:28 AM, Rickard Bäckman wrote:
>> Sorry for being brief on the RFR,
>>
>> the reason we want to do this is that having the precompiled header in
>> the "root" directory sometimes cause problems since the lookup order (at
>> least for MS CL) is:
>>
>> #1 the directory of the file
>> #2 the include path (-I /I)
>> ...
>>
>> we would like to be able to modify the include path but since all files
>> use relative includes from the "root" (src/share/vm) #1 will take
>> precedence and make it impossible to do.
>>
>> The CR can also be seen here:
>> http://monaco.sfbay.sun.com/detail.jsf?cr=7106766
>>
>> Thanks
>> Rickard
>>
>> On 11/01/2011 07:21 AM, Rickard Bäckman wrote:
>>> 7106766: Move the precompiled header from the src/share/vm directory
>>>
>>> Moved the precompiled.hpp file from src/share/vm to
>>> src/share/vm/precompiled
>>>
>>> http://cr.openjdk.java.net/~rbackman/7106766/
>>>
>>> Thanks
>>> Rickard
>>
>
More information about the hotspot-runtime-dev
mailing list