Request for review (M / Verifier Error messages)

[Keith McGuigan]

Anyone?

On 7/26/2012 6:02 PM, Keith McGuigan wrote:
> Hello,
>
> Would appreciate any review of the following code:
> http://cr.openjdk.java.net/~kamg/7116786/
>
> This code adds additional information to VerifyError messages to make it
> easier to diagnose bytecode problems in the field.  It may be a full (or
> partial) solution for JEP 136 (http://openjdk.java.net/jeps/136).
>
> The basic idea is to create an ErrorContext object when a verification
> error occurs and populate it with context information so that things
> like the current frame, stackmaps, and bytecodes can be included in the
> VerifyError's message.  In addition a diagnostic flag,
> -XX:+VerifyVerbose is added which prints out the details of the
> verification as it occurs.
>
> The included test case has a 'testcases.jar' file that contains
> hand-modified classfiles that trigger VerifyErrors in each possible
> location in the verifier.  Some cases appeared unreachable so those
> cases are missing.  I'm attaching the output of the test so you may see
> the resulting error message format.
>
> --
> - Keith