Request for review: 8004076: Move _max_locals and _size_of_parameters to ConstMethod for better sharing

Jiangli Zhou jiangli.zhou at oracle.com
Fri Dec 7 13:45:14 PST 2012


Hi,

Could I have another reviewer for the change? Either official or 
non-official reviewer is okay.

Thanks in advance.

Jiangli

On 12/05/2012 12:38 PM, Jiangli Zhou wrote:
> Hi Coleen and others,
>
> Please review the webrev for moving the Method::_max_locals and 
> Method::_size_of_parameters to ConstMethod:
>
>   http://cr.openjdk.java.net/~jiangli/8004076/webrev.00/
>
> Tested with jprt, runthese and vm.quick.testlist. No noticeable 
> performance impact with the change.
>
> ============================================================================== 
>
> logs.maxlocal_baseline.spec.1:
>   Benchmark           Samples        Mean     Stdev             
> Geomean Weight
>   specjvm98                 8      546.91     12.58
> ============================================================================== 
>
> logs.maxlocal.spec.1:
>   Benchmark           Samples        Mean     Stdev   %Diff     P  
> Significant
>   specjvm98                 8      547.44     12.13    0.10 
> 0.933            *
> ============================================================================== 
>
>
> ============================================================================== 
>
> logs.maxlocal_baseline.jbb:
>   Benchmark           Samples        Mean     Stdev             
> Geomean Weight
>   specjbb2005               3    56898.90    481.78
> ============================================================================== 
>
> logs.maxlocal.jbb:
>   Benchmark           Samples        Mean     Stdev   %Diff     P  
> Significant
>   specjbb2005               3    56901.46    613.98    0.00 
> 0.996            *
> ============================================================================== 
>
>
> Thanks,
> Jiangli



More information about the hotspot-runtime-dev mailing list