Request for code review (smallest review ever)

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Feb 14 13:23:32 PST 2012


Thumbs up!

Dan

P.S.
I've seen one where it was a single char change so the
size of the file was the same... yours added a character
so that would count as bigger... :-)

On 2/14/12 2:20 PM, keith mcguigan wrote:
>
> Well, ok, I guess it's not the smallest code change -- I think I've 
> matched this before -- but I guarantee you won't see one smaller than 
> this!
>
> It's a one-liner (a one-character-er) to accept 0 as a successful 
> return from an ioctl() call, for registering dtrace providers.
>
> http://cr.openjdk.java.net/~kamg/7145589/webrev.00/
>
> -- 
> - Keith
>


More information about the hotspot-runtime-dev mailing list