Diagnostic command fixes
Frederic Parain
frederic.parain at oracle.com
Wed Feb 15 05:08:12 PST 2012
Looks good to me.
A few minor issues I can fix just before pushing the code:
- diagnosticCommand.[ch]pp don't have modifications
-> copyright update is not required
- 2 empty lines added in diagnosticFramework.cpp
- "2012NAME" Copyright in diagnosticFramework.cpp
Thumps up!
Fred
On 2/15/12 12:38 PM, Nils Loodin wrote:
> Thank you all for suggesting even more improvements!
>
> Updated the webrev and put it here:
> http://cr.openjdk.java.net/~nloodin/7145243/webrev.02/
>
> Regards,
> Nils Loodin
>
> On Feb 14, 2012, at 18:29 , Nils Loodin wrote:
>
>> Thanks all for suggestions on improvements.
>> I have an updated webrev here:
>> http://cr.openjdk.java.net/~nloodin/7145243/webrev.01/
>>
>> Regards
>> Nils Loodin
>>
>> PS: Note - Frederic Parain has graciously taken upon himself to sponsor this. Many thanks!
>>
>> DS
>>
>> On Feb 13, 2012, at 22:58 , Nils Loodin wrote:
>>
>>> Hey all!
>>>
>>> The new diagnostic command parser needs some additional specializations for time and bytes, here included.
>>> Also a few fixes for crashes for some combinations of commandlines.
>>>
>>> Tested by throwing a lot of different arguments on the parser, also by running the tests in sun/tools/jcmd.
>>>
>>> http://cr.openjdk.java.net/~nloodin/7145243/webrev.00/
>>>
>>> I would also need a sponsor to get this in..
>>>
>>> Regards
>>> Nils Loodin
>>
>
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com
More information about the hotspot-runtime-dev
mailing list