java.library.path fix for MacOS X (7145798)

Paul Hohensee paul.hohensee at oracle.com
Fri Feb 17 14:27:18 PST 2012


Looks good.  A nit: you could use %s:%c in the sprintf format string, vis,

     sprintf(ld_library_path, "%s:%c", t, '.');

which would save allocating the "." string.

Are there any security issues with using dot on a search path?

Paul

On 2/17/12 5:06 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> Apple's version of Java includes "." in the java.library.path
> at the beginning. OpenJDK includes "." at the end of
> java.library.path on Windows. On Linux and Solaris, "." is
> not included at all.
>
> In the MacOS X port project, the relevant code was copied from
> Linux so "." is not present in java.library.path. This should
> be changed to make the OpenJDK7 version on MacOS X behave
> similar to the Apple version of Java6.
>
> Here is the webrev URL:
>
> http://cr.openjdk.java.net/~dcubed/7145798-webrev/0/
>
> There more lines of comment in there than code...
>
> Thanks, in advance, for any feedback.
>
> Dan
>


More information about the hotspot-runtime-dev mailing list