java.library.path fix for MacOS X (7145798)

[Daniel D. Daugherty]

Adding back macosx-port-dev at openjdk.java.net...

That "reply-to-list" option only takes the first token...

Thanks for the quick review!

On 2/17/12 3:35 PM, James Melvin wrote:
> Hi Dan,
>
> Some terse comments...
>
>
> >> // "." is appended to the end of java.library.path
>
> I agree with the solution to put "." at the end of the searchpath.

Thanks!


>
>
> >> #ifdef __APPLE__
>
> To be consistent, shouldn't the solution apply to all BSD releases?  If
> so, the #ifdef would not be needed.

No. Apple's Java6 has "." in the java.library.path. I have no information
that other BSDs need to have "." in the java.library.path so I'm hoping
they are more like Linux...

> >>  581  {
> >>  587  }
>
> Any particular reason you've blocked off this code?

Yes, for the local 't' context like all the other code that
builds the ld_library_path buffer...

Again, thanks for the review...

Dan


>
>
> - Jim
>
>
>
>
> On 2/17/12 5:06 PM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Apple's version of Java includes "." in the java.library.path
>> at the beginning. OpenJDK includes "." at the end of
>> java.library.path on Windows. On Linux and Solaris, "." is
>> not included at all.
>>
>> In the MacOS X port project, the relevant code was copied from
>> Linux so "." is not present in java.library.path. This should
>> be changed to make the OpenJDK7 version on MacOS X behave
>> similar to the Apple version of Java6.
>>
>> Here is the webrev URL:
>>
>> http://cr.openjdk.java.net/~dcubed/7145798-webrev/0/
>>
>> There more lines of comment in there than code...
>>
>> Thanks, in advance, for any feedback.
>>
>> Dan
>>