java.library.path fix for MacOS X (7145798)
Daniel D. Daugherty
daniel.daugherty at oracle.com
Sat Feb 18 16:22:49 PST 2012
On 2/18/12 12:49 PM, Dmitry Samersoff wrote:
> Dan,
>
> Sorry for stepping in later.
> Feel free to ignore my comments. (Thumbs up!)
The changeset is already pushed to RT_Baseline so...
> 1. sprintf is an overkill here:
>
> strcpy(..); strcat(":.");
>
> would do the same with less efforts.
Yes, but I'm matching the existing code which definitely
seems a bit verbose, but...
>
> 2. Thank you for not expanding this fix to all BSD,
> I would prefer don't have it on my FreeBSD machine ;)
You're welcome!
Dan
>
>
> -Dmitry
>
>
> On 2012-02-18 02:06, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Apple's version of Java includes "." in the java.library.path
>> at the beginning. OpenJDK includes "." at the end of
>> java.library.path on Windows. On Linux and Solaris, "." is
>> not included at all.
>>
>> In the MacOS X port project, the relevant code was copied from
>> Linux so "." is not present in java.library.path. This should
>> be changed to make the OpenJDK7 version on MacOS X behave
>> similar to the Apple version of Java6.
>>
>> Here is the webrev URL:
>>
>> http://cr.openjdk.java.net/~dcubed/7145798-webrev/0/
>>
>> There more lines of comment in there than code...
>>
>> Thanks, in advance, for any feedback.
>>
>> Dan
>>
>
>
More information about the hotspot-runtime-dev
mailing list