Request for review (XS): 7140909 Visual Studio project builds broken: need to define INCLUDE_TRACE

Bengt Rutisson bengt.rutisson at oracle.com
Mon Jan 30 06:21:13 PST 2012


Hi all,

Could I please have a couple of review for this really small change:
http://cr.openjdk.java.net/~brutisso/7140909/webrev.01/

There is only one line changed, so I'll include the diff here as well:

Background:

The fix for "7115199: Add event tracing hooks and Java Flight Recorder 
infrastructure" added this to make\windows\makefiles\vm.make:

!ifndef JAVASE_EMBEDDED
CPP_FLAGS=$(CPP_FLAGS) /D "INCLUDE_TRACE"
!endif

To keep the Visual Studio projects working the same type of change needs 
to be made to src\share\tools\ProjectCreator\BuildConfig.java

This will only affect Visual Studio projects created with the 
ProjectCreator tool (create.bat). This does not affect "normal" Windows 
builds or JPRT builds.

Thanks,
Bengt



More information about the hotspot-runtime-dev mailing list