Request for review (XS): 7140909 Visual Studio project builds broken: need to define INCLUDE_TRACE

[Staffan Larsen]

Looks good.

/Staffan

On 30 jan 2012, at 16:13, Bengt Rutisson wrote:

> 
> Just realized that I forgot to paste in the diff. Here it is if you want to save one click:
> 
> diff --git a/src/share/tools/ProjectCreator/BuildConfig.java b/src/share/tools/ProjectCreator/BuildConfig.java
> --- a/src/share/tools/ProjectCreator/BuildConfig.java
> +++ b/src/share/tools/ProjectCreator/BuildConfig.java
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2005, 2011, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -243,6 +243,7 @@
>         sysDefines.add("_WINDOWS");
>         sysDefines.add("HOTSPOT_BUILD_USER=\\\""+System.getProperty("user.name")+"\\\"");
>         sysDefines.add("HOTSPOT_BUILD_TARGET=\\\""+get("Build")+"\\\"");
> +        sysDefines.add("INCLUDE_TRACE");
>         sysDefines.add("_JNI_IMPLEMENTATION_");
>         if (vars.get("PlatformName").equals("Win32")) {
>             sysDefines.add("HOTSPOT_LIB_ARCH=\\\"i386\\\"");
> 
> 
> Bengt
> 
> On 2012-01-30 15:21, Bengt Rutisson wrote:
>> 
>> Hi all,
>> 
>> Could I please have a couple of review for this really small change:
>> http://cr.openjdk.java.net/~brutisso/7140909/webrev.01/
>> 
>> There is only one line changed, so I'll include the diff here as well:
>> 
>> Background:
>> 
>> The fix for "7115199: Add event tracing hooks and Java Flight Recorder infrastructure" added this to make\windows\makefiles\vm.make:
>> 
>> !ifndef JAVASE_EMBEDDED
>> CPP_FLAGS=$(CPP_FLAGS) /D "INCLUDE_TRACE"
>> !endif
>> 
>> To keep the Visual Studio projects working the same type of change needs to be made to src\share\tools\ProjectCreator\BuildConfig.java
>> 
>> This will only affect Visual Studio projects created with the ProjectCreator tool (create.bat). This does not affect "normal" Windows builds or JPRT builds.
>> 
>> Thanks,
>> Bengt
>> 
>