RFR: 6294277 java -Xdebug crashes on SourceDebugExtension attribute larger than 64K

[serguei.spitsyn at oracle.com]

Hi Frederic,


Thank you a lot for fixing this issue!
The fix looks good, just a couple of nits below.
I also wonder if the SA cares about this attribute.
If so, it'd make sense to file a bug.


(1) Nit: I guess, the type should be char, not u1:

1949   if (_source_debug_extension != NULL) FREE_C_HEAP_ARRAY(u1, 
_source_debug_extension, mtClass);


(2) Nit: No need to cast at 1971:

1966     char* sde = NEW_C_HEAP_ARRAY(char, (length + 1), mtClass);
. . .
1971     _source_debug_extension = (char*)sde;


Thanks,
Serguei

On 7/5/12 5:22 AM, Frederic Parain wrote:
> Greetings,
>
> The bug is described in details in the CR below.
>
> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6294277
> Webrev: http://cr.openjdk.java.net/~fparain/6294277/webrev.00/
>
> Tested with JPRT, sajdi and quick-jvmti.
>
> Thanks,
>
> Fred
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20120705/d547ef60/attachment.html