7186278: Build error after CR#6995781 / 7151532 with GCC 4.7.0

[Coleen Phillimore]

We got this patch today and David thought it looked familiar, but I 
didn't remember this report.  I'm sorry for not properly attributing 
this changeset to Yasumasa.

Coleen

On 7/31/2012 8:30 PM, David Holmes wrote:
> My sincerest apologies. This problem came in through another report 
> today and was picked up by a colleague. I knew it looked familiar but 
> I couldn't find these emails at the time. It seems my colleague did 
> find this bug report to associate the patch with but the report does 
> not contain the same detail that was exchanged in the email.
>
> Again my apologies for the omission of the attribution.
>
> David Holmes
>
> On 1/08/2012 10:19 AM, Takao, Shinji wrote:
>> Hi All,
>>
>> It seems that the Yasumasa's patch has employed in:
>> hg: hsx/hotspot-rt/hotspot: 7186278: Build error after CR#6995781 
>> /7151532 with GCC 4.7.0
>> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5e2dc722e70d
>>
>> Although that may be a simply modification, I feel odd that there is 
>> no name of Yasumasa
>> in the ChangeSet...
>>
>> I am glad if you consider him a contributor. :-)
>>
>> Thanks,
>> Shinji
>>
>>
>>> On 24/07/2012 5:13 PM, Yasumasa Suenaga wrote:
>>>> Hi David.
>>>>
>>>> Thank you for replying.
>>>>
>>>>
>>>> "NoPermGen" comes so soon?
>>>
>>> Not too far away AFAIK.
>>>
>>>> I want to build / use JDK8 on Fedora17 or later.
>>>>
>>>> So I would like you to merge this patch into mainline.
>>>
>>> The bug has been accepted it now depends on resources/priorities etc.
>>>
>>> Thanks,
>>> David
>>>
>>>>
>>>> Best regards,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2012/07/24 15:41, David Holmes wrote:
>>>>> Thank you for the report. We recently encountered a similar GCC 4.7
>>>>> issue (7172226). I think this may be addressed in the
>>> upcoming NoPermGen
>>>>> changes but we can use the patch in other release trains
>>> if necessary.
>>>>>
>>>>> David Holmes
>>>>>
>>>>> On 24/07/2012 4:09 PM, Yasumasa Suenaga wrote:
>>>>>> Hi,
>>>>>>
>>>>>> When I build JDK8 with GCC 4.7.0 on Fedora17, it fails
>>> with message as following:
>>>>>>
>>>>>> ----------
>>>>>>
>>> /usr/src/OpenJDK/8/test/jdk8/hotspot/src/share/vm/utilities/ha
>>> shtable.hpp: In instantiation of 'int Hashtable<T,
>>> F>::index_for(Symbol*) [with T = constantPoolOopDesc*; short
>>> unsigned int F = 256u]':
>>>>>>
>>> /usr/src/OpenJDK/8/test/jdk8/hotspot/src/share/vm/utilities/ha
>>> shtable.cpp:317:16:   required from here
>>>>>>
>>> /usr/src/OpenJDK/8/test/jdk8/hotspot/src/share/vm/utilities/ha
>>> shtable.hpp:263:44: error: 'hash_to_index' was not declared
>>> in this scope, and no declarations were found by
>>> argument-dependent lookup at the point of instantiation [-fpermissive]
>>>>>>
>>> /usr/src/OpenJDK/8/test/jdk8/hotspot/src/share/vm/utilities/ha
>>> shtable.hpp:263:44: note: declarations in dependent base
>>> 'BasicHashtable<256u>' are not found by unqualified lookup
>>>>>>
>>> /usr/src/OpenJDK/8/test/jdk8/hotspot/src/share/vm/utilities/ha
>>> shtable.hpp:263:44: note: use 'this->hash_to_index' instead
>>>>>> ----------
>>>>>>
>>>>>> This problem is caused by C++ template class.
>>>>>> We have to explicit references of C++ class member to access them.
>>>>>>
>>>>>>       Bug 43282 - GCC looks into dependent bases during
>>> unqualified lookup
>>>>>>       http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43282
>>>>>>
>>>>>>
>>>>>> I posted this problem on BugDatabase as a new bug.
>>>>>>
>>>>>> I've made a patch which attached in this email, and it
>>> works fine in my environment.
>>>>>> I would like to contribute this patch, and I hope to
>>> merge this patch into mainline.
>>>>>>
>>>>>> Please cooperate.
>>>>>>
>>>>>>
>>>>>> Best regards,
>>>>>> Yasumasa
>>>>>>
>>>>
>>>>
>>