request for review (S)

Dean Long dean.long at oracle.com
Sat Jun 2 13:33:58 PDT 2012


On 6/1/2012 10:58 AM, Keith McGuigan wrote:
> Hello,
>
> This fixes up a hole which I'm reasonably confident is the cause of 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7166498
>
> Webrev: http://cr.openjdk.java.net/~kamg/7166498/
> (the comment in the code explains what's going on)
>
> Thanks for any review!
>
> -- 
> - Keith

After the last iteration of the loop, aligned_bcp is invalid again, so 
any new code added after the loop would need to be careful to recompute 
it again.  How about doing something like

     NOT_PRODUCT(aligned_bcp = NULL);

after every call to check_jump_target()?

dl


More information about the hotspot-runtime-dev mailing list