7172708: 32/64 bit type issues on Windows

Staffan Larsen staffan.larsen at oracle.com
Wed Jun 6 23:55:05 PDT 2012


Looks good.

/Staffan

On 6 jun 2012, at 22:26, David Holmes wrote:

> This passed our builds and basic tests.
> 
> Looks okay to me. We need one more runtime reviewer.
> 
> David
> 
> On 6/06/2012 9:44 AM, David Holmes wrote:
>> Hi Chris,
>> 
>> This looks reasonable to me but I'm not a windows programming expert.
>> I'm running it through our JPRT build/tests system to check it out.
>> 
>> David Holmes
>> 
>> On 5/06/2012 11:46 PM, Chris Dennis wrote:
>>> diff --git a/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> b/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> --- a/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> +++ b/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> @@ -220,9 +220,15 @@
>>> #define PRIu64 "I64u"
>>> #define PRIx64 "I64x"
>>> 
>>> +#ifdef _LP64
>>> +#define PRIdPTR "I64d"
>>> +#define PRIuPTR "I64u"
>>> +#define PRIxPTR "I64x"
>>> +#else
>>> #define PRIdPTR "d"
>>> #define PRIuPTR "u"
>>> #define PRIxPTR "x"
>>> +#endif
>>> 
>>> #define offset_of(klass,field) offsetof(klass,field)



More information about the hotspot-runtime-dev mailing list