RFR(M): 7178703: Fix handling of quoted arguments and better error messages in dcmd

[Staffan Larsen]

Thanks Coleen, I'll change to == NULL and push this after the NMT changes have gone in.

/Staffan

On 27 jun 2012, at 16:37, Coleen Phillimore wrote:

> 
> Changes look good.  I have to admit I'd never seen this oopDesc::is_null() call.   Most code checks against == NULL.   I think it's only needed if the code calling it is a template where the template parameter is either oop and narrowOop.   Your code can just check against NULL,  which I think looks simpler.  If you don't agree,  you can keep this is_null call.
> 
> Coleen
> 
> On 6/27/2012 4:18 AM, Markus Grönlund wrote:
>> 
>> Staffan,
>>  
>> Changes look good.
>>  
>> Thanks for incorporating the comments for some more context about “impact” field/method.
>>  
>> Cheers
>> Markus
>>  
>> From: Staffan Larsen 
>> Sent: den 25 juni 2012 15:50
>> To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev serviceability-dev at openjdk.java.net
>> Subject: Re: RFR(M): 7178703: Fix handling of quoted arguments and better error messages in dcmd
>>  
>> Here is an updated webrev. The last one didn't compile on Solaris.
>>  
>> http://cr.openjdk.java.net/~sla/7178703/webrev.02/
>>  
>> Thanks,
>> /Staffan
>>  
>> On 21 jun 2012, at 13:30, Staffan Larsen wrote:
>> 
>> 
>> Please review the following fix to the diagnostic command framework to improve information and error messages as well as handling of quoted arguments.
>>  
>> webrev: http://cr.openjdk.java.net/~sla/7178703/webrev.01/
>>  
>> The bug hasn't been made public yet so here is the description from the bug:
>> ----
>> Error messages in the dcmd parser can be improved to include information on which argument failed to parse or did not exists.
>>  
>> Dcmd parser does not handle quoted arguments correctly (fails to parse them).
>> ----
>>  
>> A new test has been added to verify the handling of quoted arguments.
>>  
>> Thanks,
>> /Staffan
>>  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20120628/a5b96fa2/attachment-0001.html