Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

[David Holmes]

On 19/03/2012 7:13 PM, Erik Joelsson wrote:
> Thanks for the reviews!
>
> On 2012-03-19 02:21, David Holmes wrote:
>> Minor nit, when you say:
>>
>> # On 32 bit <OS-NAME> we build server and client, on 64 bit just server.
>>
>> the OS isn't actually relevant. If we ask for a 32-bit build then we
>> build both client and server; if we ask for a 64-bit build then we
>> build server only (by default).
>>
>> So AFAICS the only platform dependent part here is adding kernel on
>> Windows - right? If so then once we do the kernel->minimal transition
>> this can be refactored into the defaults section of the top-level
>> defs.make
>>
> Yes, the only platform dependent part is kernel on Windows. Will minimal
> be built on all OSes and not just Windows then? If that's the case, then
> yes, there is no need for duplicating this logic in the platform
> specific files.

Minimal is untested on windows, but should work in theory. It is 
primarily linux and works on Solaris. This is one reason I said kernel 
and minimal were not really a simple swap.

> I've created an exported change and put it here:
> http://cr.openjdk.java.net/~erikj/7141246/hotspot-change

I'll push this to hotspot-rt in the morning.

David


> /Erik