RFR(XS): 7087969: GarbageCollectorMXBean notification contains ticks vs millis

[Daniel D. Daugherty]

On 3/27/12 7:12 AM, Frederic Parain wrote:
> CR:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7087969
>
> The fix is very simple, converting ticks into milliseconds
> before using them to create the notification. This fix
> makes the notification consistent with the other API
> returning GcInfo instances.
>
> Webrev:
> http://cr.openjdk.java.net/~fparain/7087969/webrev.00/

Thumbs up.

src/share/vm/services/gcNotifier.cpp
     No comments.

> Tested manually and with JPRT by running the jdk_management suite.
> No new test has been added because the fix is in the HotSpot repository,
> and the GarbageCollectorMXBean notification unit tests are in the
> jdk repository.

You didn't mention whether you also ran with the test provided
by the submitter. There is support for putting JavaTest/JTREG
tests in hotspot/test/serviceability, but I'll have to agree
that the rest of the related tests live in jdk/test. Are you
planning to push a test to jdk repo sometime in the future?
Obviously, the usual coordination dance will have to come into
play... waiting for the right hotspot to get promoted before
pushing the test to the jdk repo... etc...

Dan



>
> Thanks,
>
> Fred
>