RFR (XS): Run SPECjbb in headless mode in JPRT

John Coomes John.Coomes at oracle.com
Tue May 22 17:30:06 PDT 2012


Mikael Vidstedt (mikael.vidstedt at oracle.com) wrote:
> 
> Thanks for the review. I updated based on your feedback.
> 
> This new webrev also re-enables the JBB testing on OSX:
> 
> http://cr.openjdk.java.net/~mikael/7155453/webrev.01

Looks good to me.

-John

> On 2012-05-22 13:24, Daniel D. Daugherty wrote:
> > On 5/22/12 2:16 PM, Mikael Vidstedt wrote:
> >>
> >> All,
> >>
> >> I'd like to get a couple of reviews of this change.
> >>
> >> We've seen problems with intermittent and hard to debug popups when 
> >> running SPECjbb on lights out OSX machines. To prevent the popups 
> >> from blocking the completion of the tests this change makes SPECjbb 
> >> run in headless mode in JPRT.
> >>
> >> http://cr.openjdk.java.net/~mikael/7155453/webrev.00
> >
> > Thumbs up.
> >
> > make/jprt.properties
> >     typo: "popup:s" -> "popups"
> >
> >     The comment kind of implies that this is a MacOS X only change,
> >     but it isn't. Maybe add one more line:
> >
> >     # but the work-around is added to all platforms to be consistent
> >
> > Dan
> >
> >
> 


More information about the hotspot-runtime-dev mailing list